Merged
Conversation
Contributor
Unit Tests Summary3 tests 2 ✅ 4s ⏱️ Results for commit c3e87dc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the latest commit from a PR is not checked out properly (in
build-check-install.yamlworkflow) for PRs coming from forks.This also makes the
build-check-install.yamlworkflow consistent with the others which already use theref: ${{ steps.branch-name.outputs.head_ref_branch }}input in a similar way.Setup
Assuming this is the latest commit on
main:These are the commits in PR not from fork:
These are the commits in PR from fork:
Old settings
Running for PR not from fork:
mainis correctly merged with latest PR commitRunning for PR from fork:
mainis checked out (not correct)Cause
This is likely because in a fork, the default branch is checked out by default if
refinput is not provided:https://github.com/actions/checkout/blob/v4.1.1/action.yml#L7-L11
New settings
Running for PR not from fork:
mainis correctly merged with latest PR commitRunning for PR from fork:
mainis also correctly merged with latest PR commit